Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "id" instead of "osm_id" ? #4

Open
nyurik opened this issue Mar 27, 2017 · 3 comments
Open

Using "id" instead of "osm_id" ? #4

nyurik opened this issue Mar 27, 2017 · 3 comments

Comments

@nyurik
Copy link
Member

nyurik commented Mar 27, 2017

Would it make sense to use the "id" field of the vector tile, instead of "osm_id"? The "id" SHOULD be unique per layer, which I think is generally the case.

@MaxSem
Copy link

MaxSem commented Mar 28, 2017

OSM ID is not guaranteed to be unique, you can totally have more than one geometry with the same osm_id in the same tile. Also, even now Meddo supports sources other than OSM. My question is does it make sense to have osm_id, ne_id, etc separately?

@nyurik
Copy link
Member Author

nyurik commented Mar 28, 2017

Wouldn't that geometry be merged into one for a tile? In any case, osm_id is a bit confusing - is it a polygon, a line, a relation id? In a general case - I think we might as well keep osm_id for now, while the data layer is being actively worked on.

@pnorman
Copy link
Member

pnorman commented Apr 4, 2017

In any case, osm_id is a bit confusing - is it a polygon, a line, a relation id?

Node IDs are passed through node_id which offsets them by 1000000000, but this isn't documented. Relations and way IDs are handled in the usual manner of relation IDs being negative. Polygon IDs don't exist since these are OSM ids, and polygons aren't part of the OSM data model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants