cross-env version 5.0.0 no longer seems to replace environment variables

[derekgreer]

I'm running bash on windows. After upgrading from cross-env 4.0.0 to 5.0.0, environment variables don't seem to be replaced the same way.

This works:

{                                                                                   
  "name": "testapp",                                                                
  "version": "1.0.0",                                                               
  "license": "MIT",                                                                 
  "config": {                                                                       
    "environment": "localhost"                                                      
  },                                                                                
  "scripts": {                                                                      
    "echo": "cross-env echo ${npm_package_config_environment} ${test}"              
  },                                                                                
  "devDependencies": {                                                              
    "cross-env": "^4.0.0"                                                           
  }                                                                                 
}  

$> test=xxx npm run echo

> exports@1.0.0 echo C:\Temp\npmtest
> cross-env echo ${npm_package_config_environment} ${test}

localhost xxx

This does not work:

{                                                                                   
  "name": "testapp",                                                                
  "version": "1.0.0",                                                               
  "license": "MIT",                                                                 
  "config": {                                                                       
    "environment": "localhost"                                                      
  },                                                                                
  "scripts": {                                                                      
    "echo": "cross-env echo ${npm_package_config_environment} ${test}"              
  },                                                                                
  "devDependencies": {                                                              
    "cross-env": "^5.0.0"                                                           
  }                                                                                 
} 

$> test=xxx npm run echo

> exports@1.0.0 echo C:\Temp\npmtest
> cross-env echo ${npm_package_config_environment} ${test}

%npm_package_config_environment% %test%

[kentcdodds]

Hi 👋

Please use cross-env-shell for this. See the README. 👍

Good luck!

[derekgreer]

Thanks for pointing me to cross-env-shell. FWIW, I read the README and saw that there was a new cross-env-shell command prior to opening this issue, but the description didn't seem to match my usage scenario and so it wasn't immediately clear it could be used in this way. For example, the README states:

The main use case for cross-env-shell is when your need an environment variable to be set across an entire inline shell script, rather than just one command.

Since I was only using a single command in my example (i.e. "echo") and was trying to substitute environment variables set for the process running npm rather than an individual script command, the description and example provided didn't seem to match my usage scenario.

Perhaps it would be beneficial to show an example of the command's use with environment variables set for the npm process rather than for a single script entry:

{
  "scripts": {
    "greet": "npm-run-all greet:*",
    "greet:english": "cross-env-shell echo Hello, $NAME!",
    "greet:spanish": "cross-env-shell echo ¡Hola, $NAME!",
    "greet:french": "cross-env-shell echo Bonjour, $NAME!"
  }
}

$> NAME=Bob npm run greet

[kentcdodds]

Agreed. Thanks @derekgreer. Could you file a PR to update the README?

[derekgreer]

Sure.

[parkerault]

I'm having a similar issue trying to use command substitution. It works in linux, but not windows.

{
  "scripts": {
    "start": "cross-env-shell COMMIT_HASH=$(git show --no-patch --format=%h) react-scripts start",
  }
}

It fails with "react-scripts was unexpected at this time" using both cross-env-shell and cross-env. Am I doing something wrong here?

Edit: I figured it out: #192 (comment)