-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add TestLessThanOrEqualAddress #122
Comments
I am applying to this issue via OnlyDust platform. My background and how it can be leveragedHey, I'm Renzo, a Software Engineer with over 5 years of experience, I recently started contributing to Web3 as a member of Dojo Coding, I have contributed in languages like Cairo and Rust already. How I plan on tackling this issue
|
Sure, assigned |
Hi, I have a question about the implementation of the hint, as there's no example for this one,
This implementation is quite similar to how the TestLessThanOrEqual hint would be, what I'm not sure about is, the result should be a Relocatable? If so, how can I do that conversion? If not, should the inputs be a Relocatable? I didn't quite get that part. Thank you! |
Hi, indeed missed providing the right one, here is a proper reference. This hint was actually introduced with Cairo 2.7.0 and the I'm currently bumping the Cairo compiler submodule to the right version so you can write and compile a Cairo program using this hint.
Yes the inputs should be The current method handling I'll update the API so that you can properly implement the |
@renzobanegass All good now, you can use |
Great, I'll get to it then! |
Does this implementation look better?
|
Open a PR, I'll make a review, it'll be much easier |
Estimated time: 0.5d
Lifespan: 1d
How-to implement a hint on the Cairo VM TS available here
Similar to the TestLessThanOrEqual hint, but expecting Relocatable instead of Felt.
Rust implementation reference of TestLessThanOrEqual
The text was updated successfully, but these errors were encountered: