Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka-controller Kafka connections pooling #3139

Closed
maschmid opened this issue Jun 8, 2023 · 0 comments · Fixed by #3493
Closed

kafka-controller Kafka connections pooling #3139

maschmid opened this issue Jun 8, 2023 · 0 comments · Fixed by #3493
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@maschmid
Copy link
Contributor

maschmid commented Jun 8, 2023

Problem

Currently, a new kafka client and an admin client is created for every reconciliation. While creating a larger deployment, this leads to hundreds of short-lived TCP connections to Kafka to be created.

We should consider using some kind of a connection pool for the kafka-controller Kafka connections.

Having a configurable connection pool would also help System Operators, as they could properly account for the number of connections from the kafka-controller when determining a proper value for Kafka max.connections setting. Currently, the number of connections is unbounded.

Persona:
Which persona is this feature for?
System Operator

Exit Criteria
kafka-controller has configurable Kafka connection pools, either global or per "bootstrap.servers".

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
there are open issues in sarama IBM/sarama#2042 , that might be needed to be either fixed first, or a workaround might be needed.

@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Jun 8, 2023
@Cali0707 Cali0707 self-assigned this Dec 5, 2023
@Cali0707 Cali0707 linked a pull request Feb 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants