feat: add telemetry to Node.js and TypeScript function templates #719
Conversation
This commit pulls in the latest version of faas-js-runtime which supports metrics exposed at /metrics. Also, concidentally, adds CloudEvent batch support, so Node.js and TypeScript functions may be invoked with a set of more than one event simultaneously. Fixes: knative#710 Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow-robot
added
kind/enhancement
size/M
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
|
I'm not sure how best to address the code style issue with pkged.go |
Signed-off-by: Lance Ball <lball@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #719 +/- ##
==========================================
+ Coverage 39.93% 40.48% +0.54%
==========================================
Files 42 42
Lines 3986 3999 +13
==========================================
+ Hits 1592 1619 +27
+ Misses 2172 2150 -22
- Partials 222 230 +8
Continue to review full report at Codecov.
|
This reverts commit 91d625b.
Signed-off-by: Lance Ball <lball@redhat.com>
knative-prow-robot
added
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| context: Context, | ||
| cloudevent?: CloudEvent | ||
| cloudevent?: CloudEvent<string> | CloudEvent<Customer> |
There was a problem hiding this comment.
I don't know TypeScript, I am just curious: would cloudevent?: CloudEvent<string | Customer> work?
There was a problem hiding this comment.
Actually it would. Nice catch.
| @@ -13,20 +13,17 @@ test('Unit: handles a valid event', (t) => { | |||
| customerId: '01234' | |||
| }; | |||
| // A valid event includes id, type and source at a minimum. | |||
| const cloudevent: CloudEvent = new CloudEvent({ | |||
| const cloudevent: CloudEvent<Customer> = new CloudEvent<Customer>({ | |||
| id: '01234', | |||
| type: 'com.example.cloudevents.test', | |||
| source: '/test', | |||
| data | |||
There was a problem hiding this comment.
why this is not data: data?
There was a problem hiding this comment.
That's just JavaScript shorthand. It works either way. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#property_definitions
|
/lgtm |
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Changes
🎁 This commit pulls in the latest version of faas-js-runtime which supports metrics exposed at /metrics. Also, concidentally, adds CloudEvent batch support, so Node.js and TypeScript functions may be invoked with a set of more than one event simultaneously.
UPDATE: This PR also includes some changes to
Makefilein order to remove any stray go.sum files that end up in the go templates. And it removes a stray go.sum file that ended up in the go templates./kind enhancement
Fixes: #710
Signed-off-by: Lance Ball lball@redhat.com