-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional labels to function deployments #261
Comments
Seems like a good idea to me, if there is the need for it now. Labels is also a very generic concept so our abstraction remains intact (just like our discussion around Secrets). |
Agree, good idea. |
+1 since we're using function labels to show/filter them in UI in the VEBA project |
I tried this, but labels have restrictions on the characters that can be used, and a slash as in |
Currently, when we deploy a function as a knative Service, we add two labels
boson.dev/function=true
andboson.dev/runtime=[runtime]
. It might be also useful to add the builder used to create the image. Since the image name and digest are already captured in theService
definition, I don't think that's necessary to add as a label. But would it make sense to allow for alabels
section infunc.yaml
which would allow developers to easily apply labels to their functions. E.g.What do you all think?
The text was updated successfully, but these errors were encountered: