Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional labels to function deployments #261

Closed
lance opened this issue Feb 9, 2021 · 4 comments · Fixed by #373
Closed

Add additional labels to function deployments #261

lance opened this issue Feb 9, 2021 · 4 comments · Fixed by #373

Comments

@lance
Copy link
Member

lance commented Feb 9, 2021

Currently, when we deploy a function as a knative Service, we add two labels boson.dev/function=true and boson.dev/runtime=[runtime]. It might be also useful to add the builder used to create the image. Since the image name and digest are already captured in the Service definition, I don't think that's necessary to add as a label. But would it make sense to allow for a labels section in func.yaml which would allow developers to easily apply labels to their functions. E.g.

labels:
  type: telegram.message
  botId: language.filter

What do you all think?

@lkingland
Copy link
Member

Seems like a good idea to me, if there is the need for it now. Labels is also a very generic concept so our abstraction remains intact (just like our discussion around Secrets).

@zroubalik
Copy link
Contributor

Agree, good idea.

@embano1
Copy link

embano1 commented May 26, 2021

+1 since we're using function labels to show/filter them in UI in the VEBA project

@lance
Copy link
Member Author

lance commented Jul 19, 2021

It might be also useful to add the builder used to create the image

I tried this, but labels have restrictions on the characters that can be used, and a slash as in quay.io/boson-project/some-builder is not acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants