Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defmt-itm does not compile for ARMv6-M #365

Closed
japaric opened this issue Feb 2, 2021 · 0 comments · Fixed by #368
Closed

defmt-itm does not compile for ARMv6-M #365

japaric opened this issue Feb 2, 2021 · 0 comments · Fixed by #368
Assignees
@Urhengulas
Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request

Comments

@japaric
Copy link
Member

japaric commented Feb 2, 2021

Those microcontrollers don't have an ITM peripheral. Instead of raising several, unintelligible errors when compiled we should use compile_error! to tell the user that this crate cannot be used on Cortex-M0(+) chips.
@jonas-schievink jonas-schievink added difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request labels Feb 3, 2021
@Urhengulas Urhengulas mentioned this issue Feb 7, 2021
Merged
@bors bors bot closed this as completed in 4cbf0b9 Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Urhengulas Urhengulas

Labels
difficulty: easy Pretty easy to solve good first issue Good for newcomers priority: low Low priority for the Knurling team status: needs PR Issue just needs a Pull Request implementing the changes type: enhancement Enhancement or feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

defmt-itm: Raise compile error on armv6m knurling-rs/defmt
3 participants
@jonas-schievink @japaric @Urhengulas