Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using fswatch for dep-notify #125

Closed
mattmoor opened this issue Jan 24, 2020 · 6 comments
Closed

Consider using fswatch for dep-notify #125

mattmoor opened this issue Jan 24, 2020 · 6 comments

Comments

@mattmoor
Copy link
Collaborator

http://emcrisostomo.github.io/fswatch/

@mattmoor
Copy link
Collaborator Author

Thanks to @jbeda for the pointer :D

@jonjohnsonjr
Copy link
Collaborator

Maybe worth poking around fsnotify/fsnotify#11

@mattmoor
Copy link
Collaborator Author

@rhuss was saying in knative slack that fswatch works well on macOS

@rhuss
Copy link

rhuss commented Mar 11, 2020

We used fsnotify first for our hot-reload needs in https://github.com/knative/client/blob/db569fae177eb41d688399c33f2d9de64875568f/hack/build.sh#L200-L223 but it turned out to be totally untreliably on macOS (fake detects as well as non-detects). Since we switched to fswatch everything is working as expected.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@mattmoor
Copy link
Collaborator Author

watch is deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants