From 5ab49d156f5c9f10d9ac168c0ba23a579d2de079 Mon Sep 17 00:00:00 2001 From: Keith O'Hara Date: Sun, 28 Apr 2024 11:27:23 -0400 Subject: [PATCH] fix tests for fabsf and fabsl --- tests/fabsf.cpp | 23 ++++++++++++----------- tests/fabsl.cpp | 43 ++++++++++++++++++++++--------------------- 2 files changed, 34 insertions(+), 32 deletions(-) diff --git a/tests/fabsf.cpp b/tests/fabsf.cpp index 53e5862..b9e1ea1 100644 --- a/tests/fabsf.cpp +++ b/tests/fabsf.cpp @@ -27,20 +27,21 @@ int main() { print_begin("fabsf"); - // + // note: we use std::fabs instead of std::fabsf due to + // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79700 - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, 0.0f); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf,-0.0f); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, 1.0f); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf,-1.0f); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, 0.0f); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs,-0.0f); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, 1.0f); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs,-1.0f); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, std::numeric_limits::lowest()); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, std::numeric_limits::min()); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, std::numeric_limits::max()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, std::numeric_limits::lowest()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, std::numeric_limits::min()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, std::numeric_limits::max()); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, std::numeric_limits::quiet_NaN()); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, std::numeric_limits::infinity()); - GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabsf, -std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, std::numeric_limits::quiet_NaN()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsf,std::fabs, -std::numeric_limits::infinity()); // diff --git a/tests/fabsl.cpp b/tests/fabsl.cpp index e53d58c..92024fa 100644 --- a/tests/fabsl.cpp +++ b/tests/fabsl.cpp @@ -27,33 +27,34 @@ int main() { print_begin("fabsl"); - // + // note: we use std::fabs instead of std::fabsl due to + // https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79700 - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, 0.0); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl,-0.0); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, 1.0); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl,-1.0); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, 0.0); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs,-0.0); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, 1.0); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs,-1.0); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, 0.0L); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl,-0.0L); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, 1.0L); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl,-1.0L); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, 0.0L); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs,-0.0L); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, 1.0L); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs,-1.0L); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::lowest()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::min()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::max()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::lowest()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::min()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::max()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::lowest()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::min()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::max()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::lowest()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::min()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::max()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::quiet_NaN()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::infinity()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, -std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::quiet_NaN()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, -std::numeric_limits::infinity()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::quiet_NaN()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, std::numeric_limits::infinity()); - GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabsl, -std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::quiet_NaN()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, std::numeric_limits::infinity()); + GCEM_TEST_COMPARE_VALS(gcem::fabsl,std::fabs, -std::numeric_limits::infinity()); //