Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose available ResourceFlavors from the ClusterQueue in the LocalQueue status. #3143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Expose available ResourceFlavors from the ClusterQueue in the LocalQueue status. #3143

wants to merge 1 commit into from
+501 −33

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Sep 26, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Expose available ResourceFlavors from the ClusterQueue in the LocalQueue status.

Which issue(s) this PR fixes:

Fixes #3122

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Exposed available ResourceFlavors from the ClusterQueue in the LocalQueue status.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 6e16faf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/670d2fa16c39d30008cdd072
😎 Deploy Preview https://deploy-preview-3143--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @alculquicondor

mbobrovskyi
mbobrovskyi commented Sep 26, 2024
View reviewed changes
pkg/cache/cache.go Outdated Show resolved Hide resolved
@mbobrovskyi
Copy link
Contributor Author

/retest pull-kueue-test-integration-main

@k8s-ci-robot
Copy link
Contributor

@mbobrovskyi: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kueue-build-image-main
  • /test pull-kueue-test-e2e-main-1-28
  • /test pull-kueue-test-e2e-main-1-29
  • /test pull-kueue-test-e2e-main-1-30
  • /test pull-kueue-test-e2e-main-1-31
  • /test pull-kueue-test-integration-main
  • /test pull-kueue-test-kjobctl
  • /test pull-kueue-test-multikueue-e2e-main
  • /test pull-kueue-test-scheduling-perf-main
  • /test pull-kueue-test-unit-main
  • /test pull-kueue-verify-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-kueue-build-image-main
  • pull-kueue-test-e2e-main-1-28
  • pull-kueue-test-e2e-main-1-29
  • pull-kueue-test-e2e-main-1-30
  • pull-kueue-test-e2e-main-1-31
  • pull-kueue-test-integration-main
  • pull-kueue-test-multikueue-e2e-main
  • pull-kueue-test-scheduling-perf-main
  • pull-kueue-test-unit-main
  • pull-kueue-verify-main

In response to this:

/retest pull-kueue-test-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mbobrovskyi
Copy link
Contributor Author

mbobrovskyi commented Sep 26, 2024 •
edited
Loading

/test pull-kueue-test-integration-main

Due to #3144.

@mbobrovskyi mbobrovskyi force-pushed the feature/expose-flavors-in-local-queue-status branch from c9a0f42 to 61629ef Compare September 26, 2024 13:40
@tenzen-y
Copy link
Member

Is there any decision to implement this API in the LocalQueue level?

@alculquicondor
Copy link
Contributor

I don't see any high-level concerns. Do you have any?

@mbobrovskyi mbobrovskyi force-pushed the feature/expose-flavors-in-local-queue-status branch from 61629ef to eba6ab5 Compare September 26, 2024 23:55
@mbobrovskyi mbobrovskyi changed the title Expose available ResourceFlavors in LocalQueue Status. Expose available ResourceFlavors from the ClusterQueue in the LocalQueue status. Sep 27, 2024
@mimowo
Copy link
Contributor

mimowo commented Oct 1, 2024

I don't have any high-level concerns about the approach. However, from the process perspective it might be better to include a small one-pager KEP for it? WDYT @alculquicondor @tenzen-y ?

@alculquicondor
Copy link
Contributor

Yeah, it doesn't hurt

@tenzen-y
Copy link
Member

tenzen-y commented Oct 1, 2024

I don't have any high-level concerns about the approach. However, from the process perspective it might be better to include a small one-pager KEP for it? WDYT @alculquicondor @tenzen-y ?

Basically, I agree with this enhancement.
But, I would like to seek the possibility of API since we may want to expose other information related to ResourceFlavor something like topology or nodeSelector.

@tenzen-y
Copy link
Member

tenzen-y commented Oct 1, 2024

I don't have any high-level concerns about the approach. However, from the process perspective it might be better to include a small one-pager KEP for it? WDYT @alculquicondor @tenzen-y ?

Basically, I agree with this enhancement. But, I would like to seek the possibility of API since we may want to expose other information related to ResourceFlavor something like topology or nodeSelector.

I did not indicate that we should expose that information. But, evaluations would be worth it.

@mbobrovskyi
Copy link
Contributor Author

I don't have any high-level concerns about the approach. However, from the process perspective it might be better to include a small one-pager KEP for it? WDYT @alculquicondor @tenzen-y ?

Created #3181.

@mbobrovskyi mbobrovskyi mentioned this pull request Oct 2, 2024
Merged
@mbobrovskyi
Copy link
Contributor Author

/hold for #3181

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/expose-flavors-in-local-queue-status branch from d63f561 to fd0ed8b Compare October 7, 2024 06:28
@mbobrovskyi mbobrovskyi marked this pull request as draft October 14, 2024 13:35
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/expose-flavors-in-local-queue-status branch 2 times, most recently from ea8e7f9 to e5aa4c3 Compare October 14, 2024 13:40
@mbobrovskyi mbobrovskyi marked this pull request as ready for review October 14, 2024 14:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/expose-flavors-in-local-queue-status branch from e5aa4c3 to 6e16faf Compare October 14, 2024 14:50
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice left review comments

@varshaprasad96 varshaprasad96 varshaprasad96 left review comments

@denkensk denkensk Awaiting requested review from denkensk

@mimowo mimowo Awaiting requested review from mimowo

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Flavors in LocalQueue Status
7 participants
@mbobrovskyi @k8s-ci-robot @tenzen-y @alculquicondor @mimowo @KPostOffice @varshaprasad96