Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kompose fails to convert cpu resources from a second (override) docker-compose yaml file #1106

Closed
mikegerber opened this issue Feb 14, 2019 · 9 comments · Fixed by #1214
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mikegerber
Copy link

mikegerber commented Feb 14, 2019

I am using a second Compose YAML to override e.g. the image in docker-compose.yml. This works as intended, however, kompose fails to include cpu resources I specify in the second YAML:

% kompose convert --stdout -f docker-compose.yml -f tmp-docker-compose-deploy.yml | grep cpu
%

If I merge the two YAML files manually, kompose includes the cpu resources:

% kompose convert --stdout -f docker-compose-manually-merged.yml | grep cpu
              cpu: "1"
              cpu: "1"
%

YAML files (.zip)

@mikegerber
Copy link
Author

mikegerber commented Feb 14, 2019

To reproduce, use the YAMLs in the .zip, and also create an empty docker.env:

touch docker.env

@mikegerber
Copy link
Author

% kompose version
1.17.0 (a74acad)

@mikegerber
Copy link
Author

Also fails with current HEAD:

% kompose version
1.17.0 (66ac4af)

@mikegerber
Copy link
Author

Same for:

deploy:
  replicas: 2

Tested with kompose 1.18.0 this time.

@hangyan hangyan self-assigned this Mar 25, 2019
@hangyan hangyan added the kind/bug Categorizes issue or PR as related to a bug. label Mar 25, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2019
@mikegerber
Copy link
Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 22, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 22, 2019
@mikegerber
Copy link
Author

Of course this bug report stale because there was no bug fix (or no visible bug fix). I am not going to instruct the bot to remove the label again.

@hangyan hangyan removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants