Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error on extraneous/unexpected cli input #193

Closed
dustymabe opened this issue Oct 7, 2016 · 3 comments
Closed

error on extraneous/unexpected cli input #193

dustymabe opened this issue Oct 7, 2016 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dustymabe
Copy link
Contributor

we should probably error out if we get extra arguments/input on the CLI that we don't expect or understand. One example of this is when I was trying to start the gitlab example but I was doing it wrong:

[vagrant@f24 examples (upstreammaster=)]$ ../kompose --version
kompose version 0.1.1 (5a37bf0)
[vagrant@f24 examples (upstreammaster=)]$ ../kompose up docker-gitlab.yml 
We are going to create Kubernetes deployments and services for your Dockerized application. 
If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead. 

INFO[0000] Successfully created service: web            
INFO[0000] Successfully created service: redis          
INFO[0000] Successfully created deployment: web         
INFO[0000] Successfully created deployment: redis       

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods' for details.

So you can see I was trying to run gitlab, but I didn't specify things like I should have: kompose -f docker-gitlab.yml up. This means that it actually ignored the docker-gitlab.yml that I passed on the command line and used the default docker-compose.yml instead and it looks like the application is brought up (if you aren't paying attention too close).

Now if instead it would error out when it detected extraneous input then I would have found out what was wrong sooner than later.

@ngtuna ngtuna added the bug label Oct 7, 2016
@procrypt
Copy link
Contributor

@dustymabe can I work on it, if no one else working on it.

@sebgoa
Copy link
Contributor

sebgoa commented Oct 12, 2016

@procrypt just assigned it to you.

@procrypt
Copy link
Contributor

@sebgoa Thanks :)

This was referenced Oct 17, 2016
@kadel kadel added kind/bug Categorizes issue or PR as related to a bug. and removed bug labels Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants