Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with unsupported keys not showing up in warnings #456

Closed
cdrage opened this issue Feb 28, 2017 · 2 comments
Closed

Error with unsupported keys not showing up in warnings #456

cdrage opened this issue Feb 28, 2017 · 2 comments

Comments

@cdrage
Copy link
Member

cdrage commented Feb 28, 2017

Seems that nothing warns in regards to any of the unsupported keys from compose.go, with the exception of "networks".

This code:

  var unsupportedKey = map[string]bool{                                                                                                 
    "CgroupParent":  false,                                                                                                             
    "Devices":       false,                                                                                                             
    "DependsOn":     false,                                                                                                             
    "DNS":           false,                                                                                                             
    "DNSSearch":     false,                                                                                                             
    "DomainName":    false,                                                                                                             
    "EnvFile":       false,                                                                                                             
    "Extends":       false,                                                                                                             
    "ExternalLinks": false,                                                                                                             
    "ExtraHosts":    false,                                                                                                             
    "Hostname":      false,                                                                                                             
    "Ipc":           false,                                                                                                             
    "Logging":       false,                                                                                                             
    "MacAddress":    false,                                                                                                             
    "MemSwapLimit":  false,                                                                                                             
    "NetworkMode":   false,                                                                                                             
    "Pid":           false,                                                                                                             
    "SecurityOpt":   false,                                                                                                             
    "ShmSize":       false,                                                                                                             
    "StopSignal":    false,                                                                                                             
    "VolumeDriver":  false,                                                                                                             
    "Uts":           false,                                                                                                             
    "ReadOnly":      false,                                                                                                             
    "Ulimits":       false,                                                                                                             
    "Dockerfile":    false,                                                                                                             
    "Net":           false,                                                                                                             
    "Networks":      false, // there are special checks for Network in checkUnsupportedKey function                                     
  }   
@cdrage
Copy link
Member Author

cdrage commented Feb 28, 2017

For example, running:

version: "2"                                                                                                                            
                                                                                                                                        
services:                                                                                                                               
    redis:                                                                                                                              
      image: redis:3.0                                                                                                                  
      build:                                                                                                                            
        context: .                                                                                                                      
        dockerfile: foobar                                                                                                              
                                                                                                                                        
dns: 8.8.8.8                                                                                                                            
                                                                                                                                        
hostname: foobar   

Only produces an error from build being passed in. That's it.

@cdrage
Copy link
Member Author

cdrage commented Feb 28, 2017

Ahhhh nevermind, it was a problem with my build. a git --reset and a git clean -d -f then a make build solved it.

@cdrage cdrage closed this as completed Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant