Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commenting test case temporarily #564

Closed
surajnarwade opened this issue Apr 20, 2017 · 1 comment
Closed

commenting test case temporarily #564

surajnarwade opened this issue Apr 20, 2017 · 1 comment

Comments

@surajnarwade
Copy link
Contributor

PR #562 is failing due to test case,

convert::expect_success_and_warning: Running: 'kompose --provider=openshift -f /home/travis/gopath/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/ngnix-node-redis/docker-compose.yml convert --stdout -j' expected_output: '/home/travis/gopath/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/ngnix-node-redis/output-os.json' expected_warning: 'Buildconfig using https://github.com/kubernetes-incubator/kompose.git::HEAD as source.

So as of now. I think we should comment out the test case and will pass the #562, so that #454 will get pass. after successful build. I will again add the test case.
cc @cdrage @surajssd @procrypt @containscafeine

@surajnarwade
Copy link
Contributor Author

I am updating vendor in #454 only,hence closing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant