Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page not updating with navigating between subpages of the same tool, e.g. /myTool/page-1 -> /myTool/page-2 #3085

Closed
cord opened this issue Nov 27, 2020 · 4 comments
Labels
needs more info More information is required

Comments

@cord
Copy link

cord commented Nov 27, 2020

Description:

When navigating between pages of the same tool e.g.

/myTool/page-1 -> /myTool/page-2

the content is not updated.

Detailed steps to reproduce the issue on a fresh Nova installation:

install

https://novapackages.com/packages/digital-creative/collapsible-resource-manager

and a tool with pages, e.g.

https://novapackages.com/packages/digital-creative/nova-dashboard

which is using the same route, but different parameters to the url.

Related:

#3049 -> https://github.com/laravel/nova/pull/1083
#2719

@crynobone crynobone added the bug Verified bug by the Nova team label Nov 27, 2020
@crynobone
Copy link
Member

Detail.vue already contains the following:

  watch: {
    resourceId: function (newResourceId, oldResourceId) {
      if (newResourceId != oldResourceId) {
        this.initializeComponent()
      }
    },
  },

This should already cover the use case. Is there anyway I can test this on a basic Laravel Nova apllication without using the package.

@crynobone crynobone added needs more info More information is required and removed bug Verified bug by the Nova team labels Nov 27, 2020
@cord cord changed the title Page not updating with navigating between detail views of the same resource, e.g. /resources/users/1 -> /resources/users/2 Page not updating with navigating between subpages of the same tool, e.g. /myTool/page-1 -> /myTool/page-2 Nov 27, 2020
@cord
Copy link
Author

cord commented Nov 27, 2020

@crynobone thanks for checking, actually I messed up here and just corrected the name of the issue. I can confirm direct navigation between resources updates the content.

Just got some information from @milewski that he later will add more details to this issue.

@crynobone
Copy link
Member

@cord @milewski please provide steps to replicate this on a basic Nova installation (without additional packages) so I can replicate the issue locally and verify the issue.

@crynobone
Copy link
Member

crynobone commented Nov 28, 2020

Closing this for now as it seem this issue need to be fixed via digital-creative/nova-dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info More information is required
Projects
None yet
Development

No branches or pull requests

2 participants