Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect empty state during topic loading in Staging #4408

Closed
nucleogenesis opened this issue Jan 20, 2024 · 6 comments · Fixed by #4422
Closed

Incorrect empty state during topic loading in Staging #4408

nucleogenesis opened this issue Jan 20, 2024 · 6 comments · Fixed by #4422
Assignees

Comments

@nucleogenesis
Copy link
Member

Observed behavior

While navigating the staging tree on this channel: https://studio.learningequality.org/en/channels/f3d0bd6dcddd5990bf4b9ed32d71743e/#/staging/09c87bf78fcd4839afc21704a5a56eb1 I do not see any loading indicator between topic navigations. I only see "This is empty" for several seconds while the content loads.

Expected behavior

  • Do not show "this is empty" unless we know for sure it is
  • Show the same KCircularLoader on the page that you see when navigating a channel in the Library

User-facing consequences

This appears to only affect the navigation for through the staging tree. I've only encountered it on a cheffed channel, so perhaps it isn't as user-impacting as I thought it might be initially.

Steps to reproduce the issue

  1. Go to a channel where you can click to view the staging tree (ie, the one linked above)
  2. See the empty string rather than a loader

Usage Details

@nucleogenesis nucleogenesis changed the title Incorrect empty state during topic loading Incorrect empty state during topic loading in Staging Jan 20, 2024
@nick2432
Copy link
Contributor

can i work on this?

@MisRob
Copy link
Member

MisRob commented Jan 23, 2024

Hi @nick2432, thank you, we assigned you some other issues meanwhile.

@GarvitSinghal47
Copy link
Contributor

GarvitSinghal47 commented Jan 24, 2024

@MisRob i would like to work on this issue , if it is open for contribution

@bjester bjester added P1 - important Priority: High impact on UX P2 - normal Priority: Nice to have and removed P1 - important Priority: High impact on UX labels Jan 26, 2024
@bjester
Copy link
Member

bjester commented Jan 26, 2024

As noted, this issue appears to be specific to viewing the staging tree of 'cheffed' channels. @GarvitSinghal47 that situation makes this very specific and more involved in simply reproducing it. You'll have to get set up with another repository, Ricecooker, in order to reproduce this.

While you have the studio server running, within ricecooker you may run the following to 'chef' (generate) a channel:

CONTENTWORKSHOP_URL=http://localhost:8080 python tests/test_chef_integration.py

When you run the above, it will ask you for a token, which can be obtained from the account settings page.

After it completes, you should see a 'Ricecooker testing' channel in your local Studio account and a link near the top Updated resources are ready for review. When you click that link, you enter staging browsing mode.

@bjester
Copy link
Member

bjester commented Jan 26, 2024

I've assigned you @GarvitSinghal47. If it's too involved, please let us know so we can unassign you.

@GarvitSinghal47
Copy link
Contributor

I have no problem working on the shared data smoothly. Just letting you know, I'm a bit busy this week, so I'll get to it next week. Appreciate your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants