Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable - Pagination - The 'Show more' button is not localized #4729

Closed
pcenov opened this issue Sep 12, 2024 · 9 comments · Fixed by #4749
Closed

Unstable - Pagination - The 'Show more' button is not localized #4729

pcenov opened this issue Sep 12, 2024 · 9 comments · Fixed by #4749
Assignees

Comments

@pcenov
Copy link
Member

pcenov commented Sep 12, 2024

Observed behavior

For some reason the 'Show more' button is still not localized.

Expected behavior

The label of the button should be displayed in the selected UI language.

Steps to reproduce the issue

  1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
  2. Open a channel and create a folder with more than 25 resources so that the 'Show more' will be displayed
  3. Change the display language to any of the other supported languages

Additional information

pagination

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Sep 12, 2024

@radinamatic

@akolson
Copy link
Member

akolson commented Sep 12, 2024

See #4715

@akolson akolson self-assigned this Sep 14, 2024
@akolson
Copy link
Member

akolson commented Sep 14, 2024

@pcenov, unfortunately, no other translations exist for this text other than English. @marcellamaki the TreeView component has translated strings for showMore though it no longer exists(looks like was removed). Could re-adding it and using a cross component translator be an option to consider with translations now complete?

@akolson
Copy link
Member

akolson commented Sep 14, 2024

@marcellamaki I experimented using the cross component translator, but looks like we have some circular dependency issues so using it in the Node Panel would require some refactoring. Any other work around?

@radinamatic
Copy link
Member

According to the current Studio strings on Crowdin, we have 2 instances of the Show more fully translated, with IDs:

TreeView.showMore
ToggleText.more

If the cross component translation is a challenge, maybe make the string translatable, push to Crowdin, I'll recycle the existing translations, and we than pull them from Crowdin back to code.

@akolson
Copy link
Member

akolson commented Sep 16, 2024

I'll try to use the ToggleText.more and see if it works, I had tried it with TreeView.showMore and wasn't successful. Thanks Radina!

@rtibbles
Copy link
Member

Seems like maybe strings weren't reuploaded after this PR was merged? #4674

@marcellamaki
Copy link
Member

Yes, it seems like that might be the case

@akolson akolson mentioned this issue Sep 18, 2024
24 tasks
@akolson
Copy link
Member

akolson commented Sep 18, 2024

This will be handled via Crowdin. cc @marcellamaki @rtibbles

@rtibbles rtibbles self-assigned this Sep 20, 2024
@rtibbles rtibbles mentioned this issue Sep 20, 2024
24 tasks
This was referenced Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants