Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libhtml-form-perl: t/form.t fails with HTTP::Message 7.00 #50

Open
gregoa opened this issue Oct 10, 2024 · 3 comments
Open

libhtml-form-perl: t/form.t fails with HTTP::Message 7.00 #50

gregoa opened this issue Oct 10, 2024 · 3 comments

Comments

@gregoa
Copy link

gregoa commented Oct 10, 2024

We have the following bug reported to the Debian package of
HTML-Form, c.f. https://bugs.debian.org/1084899

It doesn't seem to be a bug in the packaging, so you may want to take
a look. Thanks!

------8<-----------8<-----------8<-----------8<-----------8<-----

Source: libhtml-form-perl
Version: 6.11-1
Severity: serious
Tags: upstream ftbfs
Justification: fails to build from source

After upgrading HTTP::Message to 7.00, we see the following test
failure, probably caused by
https://github.com/libwww-perl/HTTP-Message/commit/968789db338f0c4f4756573614d26e4757d56deb


t/form.t ...............
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9
ok 10
ok 11
ok 12
ok 13
ok 14
not ok 15

ok 16
...


Cheers,
gregor

------8<-----------8<-----------8<-----------8<-----------8<-----

Thanks for considering,
gregor herrmann,
Debian Perl Group

@oalders
Copy link
Member

oalders commented Oct 10, 2024

Thanks, as always, @gregoa!

@oalders
Copy link
Member

oalders commented Oct 10, 2024

Culprit is libwww-perl/HTTP-Message#196

@haarg
Copy link
Member

haarg commented Oct 10, 2024

Based on the HTML and URL specs, CRLF normalization is part of the HTML spec, not the application/x-www-form-urlencoded format. So I believe the change in HTTP-Message is correct, and HTML-Form's tests are correct, but the module needs to be updated to do the CRLF normalization that was previously happening in HTTP-Message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants