Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The BaseDriver seems to have a redundant limayaml.LimaYAML field #2636

Open
jandubois opened this issue Sep 19, 2024 · 0 comments
Open

The BaseDriver seems to have a redundant limayaml.LimaYAML field #2636

jandubois opened this issue Sep 19, 2024 · 0 comments

Comments

@jandubois
Copy link
Member

lima/pkg/driver/driver.go

Lines 75 to 76 in df5d2e6

Instance *store.Instance
Yaml *limayaml.LimaYAML

This seems to be redundant with the store.Instance.Config value that is accessible via the BaseDriver.Instance field.

If this is not redundant, then we need comments explaining the differences.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jandubois