Use cPickle with Python 2 again, to fix v1.54 performance regression #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Python 3 compatibility changes made python-memcached import pickle rather than cPickle, since the latter isn't available on Python 3: 4540332 This is fine on Python 3, since importing pickle will automatically use the faster C implementation if available, however with Python 2 this caused a 400% slowdown in memcache gets between python-memcached v1.53 and v1.54, when dealing with objects other than bytes. This mostly fixes #71, though there is still a 10-20% performance drop using current master plus this change compared to v1.53 (using Python 2.7.10).
|
@linsomniac, I don't suppose you've seen this PR? :-) |
|
@linsomniac ping? :-) |
|
Thanks for this change, sorry for the delay in looking at it. Merging. |
|
Thank you for merging :-) |
nijel
added a commit
to WeblateOrg/docker
that referenced
this pull request
Jan 30, 2018
This way we get more recent version which doesn't suffer performance issues on Python 2. See linsomniac/python-memcached#86 Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Python 3 compatibility changes made python-memcached import
picklerather thancPickle, since the latter isn't available on Python 3:4540332
This is fine on Python 3, since importing
picklewill automatically use the faster C implementation if available, however with Python 2 this caused a 400% slowdown in memcache gets between python-memcached v1.53 and v1.54, when dealing with objects other than bytes.This mostly fixes #71, though there is still a 10-20% performance drop using current master plus this change, compared to v1.53 (using Python 2.7.10).