Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does this image add to the existing official Docker hub phpMyAdmin image ? #9

Closed
williamdes opened this issue Aug 17, 2022 · 5 comments

Comments

@williamdes
Copy link

Hi from the @phpmyadmin team !
I am just curious: What does this image add to the existing official Docker hub phpMyAdmin image ?

@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

@thespad
Copy link
Member

thespad commented Aug 18, 2022

It doesn't add anything per se (over our usual pipeline benefits) but the official versions only offer a serverless FPM image or one with Apache bundled and both are over 500Mb - ours bundles nginx and is ~130Mb.

@williamdes
Copy link
Author

It doesn't add anything per se (over our usual pipeline benefits) but the official versions only offer a serverless FPM image or one with Apache bundled and both are over 500Mb - ours bundles nginx and is ~130Mb.

Indeed this is a missing variant that we can not provide, because it would involve a process supervisor (for fpm and nginx process to be insured alive) and that is not acceptable for docker official images

See: phpmyadmin/docker#346

@thespad
Copy link
Member

thespad commented Aug 18, 2022

All our images use s6 as a supervisor and our go-to is Alpine/nginx for serving web content so it made it an obvious choice. When I'm back from hoiliday I'll look at implementing all your suggestions and call out in the readme what our "USP" is compared to the official image.

@williamdes
Copy link
Author

All our images use s6 as a supervisor and our go-to is Alpine/nginx for serving web content so it made it an obvious choice. When I'm back from hoiliday I'll look at implementing all your suggestions and call out in the readme what our "USP" is compared to the official image.

Thanks
I would also love to provide this on the official image...
Nginx is so cool and performant !

@thespad thespad closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants