Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions About the model #3

Open
ShiinaMitsuki opened this issue Oct 9, 2018 · 1 comment
Open

Questions About the model #3

ShiinaMitsuki opened this issue Oct 9, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@ShiinaMitsuki
Copy link

Hi, thanks for your pytorch implementation of the center face .
I played with your code for a while, and I may found some problem.

  1. lfw dataset, It seems that you use the whole picture instead of using the face detection bounding boxes or just using center cropped images for training and testing, take a look at some pictures in the dataset,

jiang_zemin_0001

jiang_zemin_0005

by this way, too much background are envoled.

  1. overlap between training set and test set.
    for klass, name in enumerate(names):
        def add_class(image):
            image_path = os.path.join(images_root, name, image)
            return (image_path, klass, name)

        images_of_person = os.listdir(os.path.join(images_root, name))
        total = len(images_of_person)

        training_set += map(
                add_class,
                images_of_person[:ceil(total * train_val_split)])
        validation_set += map(
                add_class,
                images_of_person[floor(total * train_val_split):])

I think you should use samples listed in the pairsDevTrain.txt to train and pairsDevTest.txt to test by the lfw paper

@louis-she
Copy link
Owner

will look into it, Thanks!

@louis-she louis-she added the bug Something isn't working label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants