Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Code for Handling Google AdId on a Separate Thread #502

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

Mansi-mParticle
Copy link
Contributor

@Mansi-mParticle Mansi-mParticle commented Aug 5, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Testing Plan

  • Was this tested locally? If not, explain why.
  • Test with a sample app on Android os 14 and 15 using the simulator.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@einsteinx2 einsteinx2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this reverts the previous PR #491 and agree with the proposed solution to revert.

@Mansi-mParticle Mansi-mParticle merged commit 17928b9 into development Aug 5, 2024
24 checks passed
@Mansi-mParticle Mansi-mParticle deleted the fix/SQDSDKS-6594-ANR-googleAd-ID branch August 5, 2024 22:29
mparticle-automation added a commit that referenced this pull request Aug 6, 2024
## [5.56.5](v5.56.4...v5.56.5) (2024-08-06)

### Bug Fixes

* Remove Code for Handling Google AdId on a Separate Thread ([#502](#502)) ([17928b9](17928b9))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.56.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants