Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRC bridges make /join and /leave requests with a malformed body #1583

Closed
richvdh opened this issue Jul 26, 2022 · 3 comments
Closed

IRC bridges make /join and /leave requests with a malformed body #1583

richvdh opened this issue Jul 26, 2022 · 3 comments
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. X-External-Issue Something upstream of the bridge (library, homeserver, ircd) has caused an issue.

Comments

@richvdh
Copy link
Member

richvdh commented Jul 26, 2022

We see lots of this on requests to POST /_matrix/client/r0/join/{roomId} and POST /_matrix/client/r0/rooms/{roomId}/leave from the IRC bridges:

2022-07-26 00:01:39,758 - synapse.http.servlet - 663 - WARNING - POST-73077 - Unable to parse JSON: Expecting value: line 1 column 1 (char 0) (b'')

... which suggests it is making requests with a malformed (empty?) body. Currently Synapse accepts this, but it's not spec-compliant and we'll be fixing this in Synapse soon: matrix-org/synapse#13388.

Please could you make sure to include (at least) an empty json object in the request body?
@Half-Shot
Copy link
Contributor

These requests are handled by matrix-bot-sdk, so it's possible that library is buggy. Will take a look.

@Half-Shot Half-Shot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. label Jul 26, 2022
@Half-Shot
Copy link
Contributor

Opened turt2live/matrix-bot-sdk#248 to track the upstream bug

@Half-Shot Half-Shot added S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-External-Issue Something upstream of the bridge (library, homeserver, ircd) has caused an issue. labels Jul 26, 2022
@Half-Shot
Copy link
Contributor

Believe this has been fixed for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. X-External-Issue Something upstream of the bridge (library, homeserver, ircd) has caused an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richvdh @Half-Shot