Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2403: Add "knock" feature #2403

Merged
merged 74 commits into from
Mar 29, 2021
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
501d7ec
add knock proposal
Sorunome Jan 9, 2020
bee4e9e
move to correct msc number
Sorunome Jan 9, 2020
1ef7c17
remove stray heading
Sorunome Jan 9, 2020
1396498
remove question regarding federation api version, as it has to be v2
Sorunome Jan 9, 2020
f0411a3
make clear displayname and avatar_url are optional, add status codes
Sorunome Jan 13, 2020
776436a
forgot to update one json example
Sorunome Jan 13, 2020
53435d4
update with new endpoints
Sorunome Jan 19, 2020
5ae462d
address issues
Sorunome Feb 7, 2020
d47cb1f
Small grammatical fixes
anoadragon453 Aug 17, 2020
c92752d
Reflow text to <79 chars
anoadragon453 Aug 17, 2020
38d6708
Note that spam is a preventable, but real possibility as a result
anoadragon453 Aug 17, 2020
de038f5
Fix the response format of send_knock
anoadragon453 Aug 17, 2020
39c2168
small grammar
anoadragon453 Aug 21, 2020
74a341a
Mention that knock -> ban is possible
anoadragon453 Aug 21, 2020
716db4e
Spell out some possible abuse vectors and how to mitigate them
anoadragon453 Aug 21, 2020
d6d5858
knock->knock and rescinding of knocks are not allowed
anoadragon453 Aug 21, 2020
1051084
Switch from Power Levels -> Join Rules
anoadragon453 Aug 21, 2020
bc90f1c
Fix typo
anoadragon453 Aug 25, 2020
aad6ff4
Remove remaining traces of [200, {}] response format
anoadragon453 Aug 25, 2020
f3fc539
Move client recommendations into its own section
anoadragon453 Aug 27, 2020
651e73b
It's possible to fight against spam
anoadragon453 Aug 27, 2020
965c47b
Remove unnecessary sentence
anoadragon453 Aug 27, 2020
ae8ec66
Spec how a client is notified of pending knock progress
anoadragon453 Aug 27, 2020
5bfd65c
Federation knock_room_state and minor cleanup
anoadragon453 Aug 28, 2020
e93a19f
Indicate that this proposal requires a new room version
anoadragon453 Sep 2, 2020
c9a7b44
Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru…
anoadragon453 Sep 2, 2020
58cb299
Update proposals/2403-knock.md
anoadragon453 Sep 3, 2020
703fa07
Remove extraneous text
anoadragon453 Sep 3, 2020
61fea58
Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru…
anoadragon453 Sep 3, 2020
630f7c4
Allow users to knock over and over, removing CS complexity
anoadragon453 Sep 4, 2020
fd9d57b
Match state events sent to a remote server when inviting a user
anoadragon453 Sep 4, 2020
6e47e86
Add unstable endpoint replacements
anoadragon453 Sep 16, 2020
340f888
Mention unstable prefixes for sync, join_rules and membership events
anoadragon453 Sep 16, 2020
e58e207
Go into more depth about membership changes surrounding knocking
anoadragon453 Oct 1, 2020
9e5ac04
Explicitly state that the hs that received the knock must put in the …
anoadragon453 Oct 1, 2020
fd8176b
Clarify endpoint calls clients and servers need to use to handle knocks
anoadragon453 Oct 1, 2020
6b99228
Remove section duplicated by membership change section
anoadragon453 Oct 1, 2020
5097fad
Fix unstable prefix bullet points
anoadragon453 Oct 1, 2020
6f7bcb6
Explicitly state what changes to the auth rules are necessary
anoadragon453 Oct 1, 2020
525d1d3
Some clarifications and wording fixes
anoadragon453 Oct 5, 2020
a924f5b
Fix incorrect assumptions about the sender field of a knock event
anoadragon453 Oct 5, 2020
815dae6
Note that redactions of knocks are not a concern
anoadragon453 Oct 8, 2020
6c75b83
Address Travis and Patrick's feedback
anoadragon453 Nov 20, 2020
7dcff8f
Disallow invite->knock membership changes
anoadragon453 Nov 27, 2020
42e01b8
Add join_rules to room chunks returned on a public room dir query
anoadragon453 Feb 2, 2021
e99649c
Foreshadow power level requirements for approval/denial of knock
anoadragon453 Feb 8, 2021
51a7778
typo
anoadragon453 Feb 8, 2021
6a0d07c
Public rooms directory backwards compatibility note
anoadragon453 Feb 9, 2021
5c620de
typo fix
anoadragon453 Feb 10, 2021
d5a2a28
Note clients should try to prevent impersonation attacks during knocking
anoadragon453 Feb 15, 2021
8400877
Make ver a required parameter for make_knock
anoadragon453 Feb 17, 2021
337c87b
Add 404 on make_knock if unknown room ID
anoadragon453 Feb 17, 2021
04cd6b3
fix typo
anoadragon453 Feb 17, 2021
74f3b12
Note experimental room version ID
anoadragon453 Feb 17, 2021
248a3da
Switch /send_knock/ from v2 to v1; leave a note as to why
anoadragon453 Feb 18, 2021
eda6584
Comment on push rules
anoadragon453 Feb 18, 2021
24f61c2
Note that implementations may choose to auto-accept knock-related inv…
anoadragon453 Feb 18, 2021
e790ad2
Apply suggestions from code review
anoadragon453 Feb 24, 2021
49a7286
Allow knock->knock transitions
anoadragon453 Feb 26, 2021
c9f34e8
Link to /join/roomIdOrAlias
anoadragon453 Mar 3, 2021
c575f88
Move endpoint extras under endpoint's header
anoadragon453 Mar 3, 2021
53ad7e3
Ensure we return the room_id after knocking via the CS API
anoadragon453 Mar 3, 2021
09018be
Link to existing spec documentation on the public rooms directory
anoadragon453 Mar 3, 2021
c915b64
Update alternatives section
anoadragon453 Mar 3, 2021
6556b95
Move API endpoint sections up to the top of the proposal
anoadragon453 Mar 3, 2021
ef840c1
Split the 'Membership change to ' section into rejecting/rescinding k…
anoadragon453 Mar 3, 2021
8bfef19
Remove further traces of old /rooms/roomId/knock CS endpoint
anoadragon453 Mar 3, 2021
68d2d7c
Note that homeservers should pass down invites to the client if they …
anoadragon453 Mar 9, 2021
7f0b2d6
Update unstable endpoints from i.e xyz.amorgan/knock -> xyz.amorgan.k…
anoadragon453 Mar 23, 2021
a1a40c6
Be consistent about event auth rules
anoadragon453 Mar 23, 2021
11996fb
clarify some words
anoadragon453 Mar 24, 2021
10267df
Add missing 403/404 response codes
anoadragon453 Mar 24, 2021
9ebfd98
Apply suggestions from code review
anoadragon453 Mar 24, 2021
a8f4ada
Make join_rules field of PublicRoomChunk an optional value
anoadragon453 Mar 24, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading