Support notifying on gitlab review comments #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Apr 21, 2022
jaller94
reviewed
Apr 21, 2022
| const existing = this.debounceMRComments.get(uniqueId); | ||
| if (existing) { | ||
| clearTimeout(existing.timeout); | ||
| existing.comments = existing.comments + 1; |
There was a problem hiding this comment.
Do you know +=? :D
Suggested change
| existing.comments = existing.comments + 1; | |
| existing.comments += 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a bit tricky. GitLab doesn't have a notion of "review comments" so we've had to play a bit of a game to make it work like we have on GitHub.
Specifically, we determine a GitLab review by the following:
We also batch together several notes for the same MR into one matrix message if several of them arrive in a short period of time (5s), since GitLab sends the review comments at the same time.
I'm not particularly happy with this approach, but I think it's probably better than not having them.