Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub/GitLab state config not being honoured #346

Merged
merged 15 commits into from
May 12, 2022
Merged

Fix GitHub/GitLab state config not being honoured #346

merged 15 commits into from
May 12, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented May 9, 2022 •
edited
Loading

Fixes #344

This was broken in #330 when we started using the output of the validation function as the config passed to the connections, so any configuration not handled by that validation function would be forgotten about. This PR:

  • Uses ajv to ensure that we validate every expected property
  • Adds some tests to cover a small amount of GitHubRepoConnection, enough to know that this bug is fixed.

@Half-Shot Half-Shot requested a review from a team May 9, 2022 12:43
tadzik
tadzik requested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic – would be great to have the tests for Gitlab as well, but I'm not going to too picky since this is already a massive improvement. Left a few nits here and there.

src/Connections/GithubRepo.ts Outdated Show resolved Hide resolved
src/Connections/GithubRepo.ts Outdated Show resolved Hide resolved
src/Connections/GithubRepo.ts Show resolved Hide resolved
src/Connections/GitlabRepo.ts Show resolved Hide resolved
tests/utils/UserTokenStoreMock.ts Outdated Show resolved Hide resolved
tests/connections/GithubRepoTest.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from tadzik May 11, 2022 14:25
@Half-Shot Half-Shot merged commit 9b216af into main May 12, 2022
@Half-Shot Half-Shot deleted the hs/add-tests-for-github-repo branch May 12, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub includingLabels option seems to no longer be filtering
2 participants
@Half-Shot @tadzik