Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get UserAgent from package.json #360

Merged
merged 5 commits into from
May 20, 2022
Merged

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented May 19, 2022

Fixes #359

Signed-off-by: Andrew Ferrazzutti andrewf@element.io

@tadzik tadzik requested a review from a team May 19, 2022 06:54
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from here!

You'll need a changelog entry too, see existing ones in changelog.d for inspiration.

changelog.d/359.bugfix Outdated Show resolved Hide resolved
AndrewFerr and others added 3 commits May 19, 2022 12:32
Be more precise about which UserAgent it is

Co-authored-by: Tadeusz Sośnierz <tadzik@tadzik.net>
@AndrewFerr AndrewFerr changed the title Get UserAgent from package.json (#359) Get UserAgent from package.json May 19, 2022
@AndrewFerr
Copy link
Member Author

4821438 and 97c5d79 update the changelog file to follow the proposed contribution guide.

I've also put the Signed-off-by trailer in the PR comment, as I had forgotten to signoff previous commits & am opting to use the PR comment to cover all of the commits, if that's preferable to amending the commits.

@tadzik
Copy link
Contributor

tadzik commented May 20, 2022

Still looks good. Feel free to merge when ready :)

@AndrewFerr AndrewFerr merged commit 0241a90 into matrix-org:main May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserAgent is hardcoded to 1.1.0
2 participants