Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oauth login urls for GitHub cloud having the wrong domain #377

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Fix oauth login urls for GitHub cloud having the wrong domain #377

merged 4 commits into from
Jun 27, 2022

Conversation

Half-Shot
Copy link
Contributor

Fixes #375

I ended up refactoring how we generate URLs, and adding some sanity tests.

@Half-Shot Half-Shot requested a review from a team June 17, 2022 10:26
tadzik
tadzik approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No complaints. Yay for the tests!

@Half-Shot Half-Shot merged commit c36a5e7 into main Jun 27, 2022
@Half-Shot Half-Shot deleted the hs/fix-oauth-login-urls branch June 27, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub login provides a enterprise api.github.com url rather than a cloud URL
2 participants
@Half-Shot @tadzik