Fix Webhook command #379
Merged
Fix Webhook command #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested changes
Jun 27, 2022
There was a problem hiding this comment.
Ooof, that's just bad (of us). Thanks for the fix.
Can you do the needful in https://github.com/matrix-org/matrix-appservice-bridge/blob/develop/CONTRIBUTING.md#%EF%B8%8F-pull-requests (sign off and changelog) and then we can merge.
Signed-off-by: Damien Gaignon <damien.gaignon@gmail.com>
|
Is this conform ? Never had to do this ^^ |
Yeah, this looks good. The signoff is so we can do the correct legal things, and the changelog is so we have a nice, user facing log entry when we do a release. Thanks for taking the time to do it :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #357 and part of #378 .