Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the same GitLab repo to be bridged to multiple rooms #406

Merged
merged 3 commits into from
Jul 11, 2022
Merged

Allow the same GitLab repo to be bridged to multiple rooms #406

merged 3 commits into from
Jul 11, 2022

Conversation

Half-Shot
Copy link
Contributor

This was a mistake where we didn't correctly scope the filter to the same room.

AndrewFerr
AndrewFerr approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - correct & concise

@Half-Shot Half-Shot merged commit 74a3611 into main Jul 11, 2022
@Half-Shot Half-Shot deleted the hs/properly-check-roomid-gitlab-repo branch July 11, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @AndrewFerr