Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: After a successful gossip of the key backup decryption key, UTDs in history are not automatically fixed #26312

Closed
BillCarsonFr opened this issue Oct 5, 2023 · 4 comments · Fixed by matrix-org/matrix-js-sdk#3929 · May be fixed by matrix-org/matrix-js-sdk#3783
Closed

ElementR: After a successful gossip of the key backup decryption key, UTDs in history are not automatically fixed #26312

BillCarsonFr opened this issue Oct 5, 2023 · 4 comments · Fixed by matrix-org/matrix-js-sdk#3929 · May be fixed by matrix-org/matrix-js-sdk#3783
Assignees
@BillCarsonFr
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect

Comments

@BillCarsonFr
Copy link
Member

Steps to reproduce

Depends on a webR with that fix matrix-org/matrix-js-sdk#3778

  1. Create a new login (account with some e2ee rooms with messages), and verify using emoji/QR

Outcome

What did you expect?

After the verification, the new session will get the backup decryption key, therefore should decrypt history automatically.
Currently only partial history is decrypted (due to key requests).

Notice that if you verify with passphrase, a call is made to download all keys from backup. But it's not done by js-sdk, it's done by the react-sdk (by a promise in usePassPhrase() of SetupEncryptionStore.ts.

What happened instead?

You have to manually go to settings and tap on restore.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@BillCarsonFr BillCarsonFr added T-Defect A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Oct 5, 2023
@richvdh richvdh changed the title ElementR: After a succesful gossip of the key backup decryption key, UTDs in history are not automatically fixed ElementR: After a successful gossip of the key backup decryption key, UTDs in history are not automatically fixed Oct 5, 2023
@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Oct 5, 2023
@BillCarsonFr BillCarsonFr self-assigned this Oct 5, 2023
@BillCarsonFr BillCarsonFr mentioned this issue Oct 6, 2023
Draft
3 tasks
@weeman1337
Copy link
Contributor

With Element R would this also fix #23333 ?

@BillCarsonFr BillCarsonFr removed the Z-Element-R-Blocker A blocker for enabling Element R by default label Oct 20, 2023
@github-actions github-actions bot removed the Z-Labs label Oct 20, 2023
@BillCarsonFr
Copy link
Member Author

Removed the blocker label as you will recover your history on a session per session basis (not a full import)

@richvdh
Copy link
Member

richvdh commented Nov 7, 2023 •
edited
Loading

I'm a bit unclear on what exactly is going on in this issue. Is the problem:

  1. The (full) key backup is not automatically downloaded once the backup decryption key is received? (This might be deliberate, since there is currently no sensible way to paginate key backups?) Or:
  2. Individual keys are not downloaded once the backup decryption key is received? (This is presumably because we only request key backups at decryption time, and there is no attempt to re-decrypt once the backup decryption key is received.) Or:
  3. Keys are downloaded fine, but the screen is not updated?

Or something else?

@richvdh
Copy link
Member

richvdh commented Nov 7, 2023

Seems like a combination of 1 and 2. Unclear how we proceed here. (What did legacy crypto do?)

@richvdh richvdh mentioned this issue Nov 7, 2023
Closed
@BillCarsonFr BillCarsonFr mentioned this issue Dec 1, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Defect
Projects
None yet
Milestone
No milestone
4 participants
@germain-gg @richvdh @weeman1337 @BillCarsonFr