Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Our release script does not care when the commands it invokes fail #10952

Closed
reivilibre opened this issue Sep 30, 2021 · 1 comment
Closed

Our release script does not care when the commands it invokes fail #10952

reivilibre opened this issue Sep 30, 2021 · 1 comment
Assignees
@reivilibre
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@reivilibre
Copy link
Contributor

reivilibre commented Sep 30, 2021 •
edited
Loading

For example: dch not being installed, towncrier exiting with a failure or git tag --sign failing because you didn't unlock your GPG passphrase in time.

These failures are ignored and the script will proceed to nudge you to pushing to GitHub anyway.

Perhaps we should have it ask you to correct the issue and retry?
@reivilibre reivilibre added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Oct 1, 2021
@reivilibre reivilibre self-assigned this Oct 1, 2021
@reivilibre reivilibre mentioned this issue Oct 1, 2021
Merged
@squahtx
Copy link
Contributor

squahtx commented Oct 21, 2021

@reivilibre looks like this has been addressed? Can we close this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reivilibre reivilibre

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@squahtx @reivilibre