Synapse 1.45.1 fails to start if Synapse S3 Storage Provider is in use

[voice06]

Description

Following a pip install -U from v1.44.0 to v.1.45.1 Synapse was unable to start. Log file shows the following:

2021-10-21 16:17:04,916 - synapse.app._base - 211 - CRITICAL - sentinel - Error during startup
Traceback (most recent call last):
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/_base.py", line 196, in wrapper
    await cb(*args, **kwargs)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/homeserver.py", line 374, in start
    await _base.start(hs)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/_base.py", line 387, in start
    hs.start_listening()
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/homeserver.py", line 290, in start_listening
    self._listener_http(self.config, listener)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/homeserver.py", line 103, in _listener_http
    resources.update(self._configure_named_resource(name, res.compress))
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/app/homeserver.py", line 181, in _configure_named_resource
    client_resource = ClientRestResource(self)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/__init__.py", line 78, in __init__
    self.register_servlets(self, hs)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/__init__.py", line 129, in register_servlets
    admin.register_servlets_for_client_rest_resource(hs, client_resource)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/admin/__init__.py", line 271, in register_servlets_for_client_rest_resource
    register_servlets_for_media_repo(hs, http_server)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/admin/media.py", line 481, in register_servlets_for_media_repo
    PurgeMediaCacheRestServlet(hs).register(http_server)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/admin/media.py", line 225, in __init__
    self.media_repository = hs.get_media_repository()
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/server.py", line 185, in _get
    dep = builder(self)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/server.py", line 619, in get_media_repository
    return MediaRepository(self)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/synapse/rest/media/v1/media_repository.py", line 108, in __init__
    backend = clz(hs, provider_config)
  File "/home/matrixserv/synapse/env/lib/python3.8/site-packages/s3_storage_provider.py", line 63, in __init__
    self.cache_directory = hs.config.media_store_path
AttributeError: 'HomeServerConfig' object has no attribute 'media_store_path'

Steps to reproduce

• Setup Synapse to use S3 Storage Provider
• Upgrade to v1.45.1
• Attempt to start

Normally Synapse would start without issue and did so up to v1.44.0, however upon upgrading to v1.45.1 I started having this issue. The issue went away when I rolled back to v1.44.0

Version information

• Homeserver: ranomsonicnet.org
• Version: v1.45.1 (v1.44.0 after rollback)
• Install method: pip
• Platform: Linux - Ubuntu 20.04.3

[squahtx]

Looks like this is a duplicate of matrix-org/synapse-s3-storage-provider#64.

The synapse-s3-storage-provider module needs updating as well. If the S3 storage provider has been installed through pip, we recommend using pip install git+https://github.com/matrix-org/synapse-s3-storage-provider.git for now. The synapse-s3-storage-provider package is unofficial and not maintained by the Synapse team.