Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Audit and/or add validation to synapse/rest/client/account_validity.py #13184

Closed
2 tasks done
Tracked by #13147
DMRobertson opened this issue Jul 5, 2022 · 0 comments
Closed
2 tasks done
Tracked by #13147

Audit and/or add validation to synapse/rest/client/account_validity.py #13184

DMRobertson opened this issue Jul 5, 2022 · 0 comments
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Milestone
Validate data pas...

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Jul 5, 2022 •
edited
Loading

This is an unspecced endpoint which I think is exposed under /unstable, /api/v1, /r0 and /v3 (#8334). It should be under /_synapse if internal or /unstable if part of an MSC.

That aside:

  • GET AccountValidityRenewServlet, nothing to do here
  • POST AccountValiditySendMailServlet. Seems to take no arguments in the post body. (Probably contravenes a rule that POST to matrix APIs need to have a json object as their body.)

Oh. So these are all fine then.
@DMRobertson DMRobertson mentioned this issue Jul 5, 2022
Open
75 tasks
@DMRobertson DMRobertson changed the title synapse/rest/client/account_validity.py Audit and/or add validation to synapse/rest/client/account_validity.py Jul 5, 2022
@squahtx squahtx added P2 T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Jul 12, 2022
@DMRobertson DMRobertson added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution A-Validation 500 (mostly) errors due to lack of event/parameter validation S-Tolerable Minor significance, cosmetic issues, low or no impact to users. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P2 labels Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Validation 500 (mostly) errors due to lack of event/parameter validation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
Validate data passed to REST endpoints
Development

No branches or pull requests
2 participants
@squahtx @DMRobertson