Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support Matrix 1.3 #13953

Closed
11 tasks done
clokep opened this issue Sep 29, 2022 · 3 comments · Fixed by #14032
Closed
11 tasks done

Support Matrix 1.3 #13953

clokep opened this issue Sep 29, 2022 · 3 comments · Fixed by #14032
Assignees
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Sep 29, 2022

We should finish up implementation of Matrix 1.3, the first thing to do is to make a checklist of remaining tasks from the release notes (https://matrix.org/blog/2022/06/16/matrix-v-1-3-release#the-full-changelog):


Client-Server API

  • Deprecate the sender_key and device_id on m.megolm.v1.aes-sha2 events, and the sender_key on m.room_key_request to-device messages, as per MSC3700.
  • Make from optional on GET /_matrix/client/v3/messages to allow requesting events from the start or end of the room history, as per MSC3567.
  • Add refresh tokens, per MSC2918. MSC2918 Refresh tokens implementation #9450
  • Describe a structured system for event relationships, as per MSC2674.
  • Describe how relationships between events can be "aggregated", as per MSC2675 and MSC3666.

Server-Server API

Application Service API

Room Versions


Other remaining things from above:

@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Sep 29, 2022
@clokep clokep mentioned this issue Sep 29, 2022
13 tasks
@clokep
Copy link
Member Author

clokep commented Sep 29, 2022

I'm unsure if MSC3700 has anything for the server to do or not, but I found some of those keys by grepping the source.

@clokep
Copy link
Member Author

clokep commented Oct 3, 2022

  • Deprecate the sender_key and device_id on m.megolm.v1.aes-sha2 events, and the sender_key on m.room_key_request to-device messages, as per MSC3700

From a conversation in #synapse-dev it seems like there is nothing to do for MSC3700, @erikjohnston's summary:

Yeah, [the sender_key and device_id] are only used as a dirty "oh look we don't know about that device and it should be cached whoops lets go and invalidate our cache"

@clokep
Copy link
Member Author

clokep commented Oct 3, 2022

Refresh tokens can be disabled currently.

I believe this is fine since the spec says:

Handling of clients that do not support refresh tokens is up to the homeserver; clients indicate their support for refresh tokens by including a refresh_token: true property in the request body of the /login and /register endpoints. For example, homeservers may allow the use of non-expiring access tokens, or may expire access tokens anyways and rely on soft logout behaviour on clients that don’t support refreshing.

@clokep clokep self-assigned this Oct 3, 2022
@MadLittleMods MadLittleMods added the A-Spec-Compliance places where synapse does not conform to the spec label Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Spec-Compliance places where synapse does not conform to the spec T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants