Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Audit and/or add validation to synapse/rest/client/devices.py #14052

Closed
5 tasks
Tracked by #13147
DMRobertson opened this issue Oct 4, 2022 · 0 comments · Fixed by #14054
Closed
5 tasks
Tracked by #13147

Audit and/or add validation to synapse/rest/client/devices.py #14052

DMRobertson opened this issue Oct 4, 2022 · 0 comments · Fixed by #14054
Assignees
@DMRobertson
Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Validation 500 (mostly) errors due to lack of event/parameter validation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 4, 2022 •
edited
Loading

  • DevicesRestServlet
    • GET
  • DeleteDevicesRestServlet
    • POST (not DELETE???)
  • DeviceRestServlet
    • GET
    • DELETE
    • PUT
  • DehydratedDeviceServlet
    • GET
    • PUT
  • ClaimDehydratedDeviceServlet
    • POST
@DMRobertson DMRobertson mentioned this issue Oct 4, 2022
Open
75 tasks
@DMRobertson DMRobertson changed the title synapse/rest/client/devices.py Audit and/or add validation to synapse/rest/client/devices.py Oct 4, 2022
@DMRobertson DMRobertson added A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Validation 500 (mostly) errors due to lack of event/parameter validation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact labels Oct 4, 2022
@DMRobertson DMRobertson changed the title Audit and/or add validation to synapse/rest/client/devices.py Audit and/or add validation to synapse/rest/client/devices.py Oct 4, 2022
This was referenced Oct 4, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
A-Device-List-Tracking Telling clients about other devices. Often related to E2EE. A-Validation 500 (mostly) errors due to lack of event/parameter validation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Pydantic to validate /devices endpoints matrix-org/synapse
1 participant
@DMRobertson