Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

remove pin on prometheus-client <0.9.0 #8831

Closed
richvdh opened this issue Nov 26, 2020 · 2 comments · Fixed by #8875
Closed

remove pin on prometheus-client <0.9.0 #8831

richvdh opened this issue Nov 26, 2020 · 2 comments · Fixed by #8875
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Nov 26, 2020

we should check that prom-client 0.9.0 doesn't break anything, and then bump the pin.

Indeed, given it's now been a few years since prom-client 0.4.0 broke the world, maybe we should remove the pin altogether?

@clokep clokep added Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution maintenance z-p2 (Deprecated Label) labels Nov 30, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

I don't know what prometheus_client is, but I edited my python_dependencies.py file to see if I could run synapse with version 0.9.0, and everything appears to be working fine, so I could open a pull request for that if you'd like. But I'm not a synapse expert, I just run a small server, and all I know is that removing the pin worked so I can use synapse again. Is there any official tests that need to be done, or can we update python_dependencies.py?

@anoadragon453
Copy link
Member

@jordanbancino If you could create a PR that removes the pin, having the CI run over it and pass would be a great start!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants