Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Update.Result.status with enum values #55

Closed
ppamorim opened this issue Oct 5, 2020 · 0 comments · Fixed by #71
Closed

Replace Update.Result.status with enum values #55

ppamorim opened this issue Oct 5, 2020 · 0 comments · Fixed by #71
Assignees
@ppamorim
Labels
breaking-change The related changes are breaking for the users enhancement New feature or request

Comments

@ppamorim
Copy link
Contributor

ppamorim commented Oct 5, 2020 •
edited
Loading

Summary

When using the object Update.Result you can find the value status, currently this value is a String, would be nice to replace it with an enum.
@ppamorim ppamorim added enhancement New feature or request breaking-change The related changes are breaking for the users labels Oct 5, 2020
@ppamorim ppamorim self-assigned this Oct 5, 2020
@ppamorim ppamorim linked a pull request Oct 10, 2020 that will close this issue
Change the update status as enum and rename Type into UpdateType in Update model #71
Merged
@bors bors bot closed this as completed in #71 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppamorim ppamorim

Labels
breaking-change The related changes are breaking for the users enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ppamorim