Support for DateTime constructors in expressions #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simple template mapping approach here gets it slightly right, but it needs to support DateTimeKind in the constructor to begin to get DateTimeOffset correct.
A complicated constructor to support new DateTimeOffset(dt, offset) that converts TimeSpans to offsets, server-side, by formatting the correct offset string. It seems like the DateTimeOffsetDatumConverter isn't handling the offsets the way I would expect; I've made a change here, but it breaks the tests. The tests need to be re-evaluated to ensure my change is accurate... it might not be.
Took raw values out of RethinkDB for time constructions in local and with offsets, and ensured that DateTimeOffsetDatumConverter matches both creating the objects and the datums for both cases. Confirmed that offsets were not working correctly before these upgrades.
mfenniak
added a commit
that referenced
this pull request
Oct 31, 2014
Support for DateTime constructors in expressions; fixes #154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address issue #154.
This is currently at a starting-point stage. DateTime works alright, but DateTimeOffset will need additional magic in order to work.