Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Peek UI no longer shows stacktrace #25555

Closed
weinand opened this issue Apr 27, 2017 · 5 comments
Closed

Exception Peek UI no longer shows stacktrace #25555

weinand opened this issue Apr 27, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Apr 27, 2017

  • VSCode Version: Insiders 1.12.0
  • OS Version: macOS

Steps to Reproduce:

  • throw exception

  • no stacktrace:

    2017-04-27_16-06-12

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority labels Apr 27, 2017
@weinand weinand added this to the April 2017 milestone Apr 27, 2017
@weinand weinand self-assigned this Apr 27, 2017
@weinand
Copy link
Contributor Author

weinand commented Apr 27, 2017

The problem is that the stacktrace attribute uses a "getter" which is not triggered if the handle is 0.

@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2017

I still see this with latest unsigned insiders, commit 31a5fb2
@weinand when did you update node-debug in master?

@isidorn isidorn removed the verified Verification succeeded label Apr 28, 2017
@weinand
Copy link
Contributor Author

weinand commented Apr 28, 2017

The latest unsigned insiders works for me. So the fix is in.

@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2017

node 6.10

console.log({a: 'a\nb'});

var t = 'C:\\Users\\User';
var x1 = 9;x1= 10;
console.log(msg);
// https://www.google.com
// sdadsasad sdadas dsadasdsa ddassd
var text = "some text";
var t = {
	hello: "asdads"
}
var o = {};
o['hello world'] = 123;
debugger;
var t = 5 / 0;
var m = [];
console.log(m[0]);
try {
	throw new Error('hello');
} catch (e) {
	console.log(e);
}

@isidorn isidorn added the verified Verification succeeded label Apr 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Apr 28, 2017

Works fine, I had an old version of node debug.
@weinand once I cleared local storage from disabled extensions node was working fine

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants