Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transforms] Extends the list of supported data augmentations #730

Closed
2 of 3 tasks
fg-mindee opened this issue Dec 20, 2021 · 8 comments
Closed
2 of 3 tasks

[transforms] Extends the list of supported data augmentations #730

fg-mindee opened this issue Dec 20, 2021 · 8 comments
Assignees
Labels
module: transforms Related to doctr.transforms topic: object detection Related to the task of object detection
Milestone

Comments

@fg-mindee
Copy link
Contributor

fg-mindee commented Dec 20, 2021

As discussed in #654, the artefact detection needs to improve its robustness. In order to do so and prevent overfitting, I would suggest gradually extending the list of our supported transformations:

Ideally, a given transform should be implemented in doctr/transforms/modules so that with the corresponding backend, we can do:

transfo = ....
pil_img = ... 
augmented_img = transfo(pil_img)

for transformations that only change the image.

and:

transfo = ....
pil_img = ... 
target = {...}
augmented_img, augmented_target = transfo(pil_img, target)

for transformations that alter the target. In doing so, that will work nicely with our Dataloaders 👍

@felixdittrich92
Copy link
Contributor

@frgfm only @SiddhantBahuguna PR left or do you have other augmentations in mind ? :)

@frgfm
Copy link
Collaborator

frgfm commented Sep 21, 2022

For now, I think the random perspective would be the last one required yeah 👍

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Sep 25, 2022

Hi @SiddhantBahuguna any way in near future that you finish your draft PR ? :)
Or should we keep it free to take ?

@felixdittrich92 felixdittrich92 modified the milestones: 0.6.0, 0.7.0 Sep 26, 2022
@SiddhantBahuguna
Copy link
Contributor

Hi @SiddhantBahuguna any way in near future that you finish your draft PR ? :) Or should we keep it free to take ?

Greetings @felixdittrich92 , I am really sorry for the unwanted delay.
I will get it done this week positively :) Sorry again !

@felixdittrich92
Copy link
Contributor

Sounds nice 🤗 👍

@felixdittrich92
Copy link
Contributor

@SiddhantBahuguna Do you think you could finish your PR that we can close this ? :)

@felixdittrich92
Copy link
Contributor

@odulcy-mindee I think we can close this ?
I don't see any issues with different perspectives (detection models) your dataset seems to capture this already well.
Or do you think we should add RandomPerspective as last one ftm ?

@odulcy-mindee
Copy link
Collaborator

Yeah, this issue can be closed, that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: transforms Related to doctr.transforms topic: object detection Related to the task of object detection
Projects
None yet
Development

No branches or pull requests

5 participants