Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4591): only set loadBalanced on handshake when explicitly set #3386

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 26, 2022

Description

What is changing?

We only set loadBalanced on the initial hello when it is explicitly provided and set to true.

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Spec compliance.

Note that the load balancer tests still fail. https://jira.mongodb.org/browse/SERVER-69146 has been filed to potentially revert the server changes so that apiStrict: true can be used with load balanced mode. If it turns out the server change is intended behavior, then there will probably be a drivers ticket to skip these tests on load balanced topologies.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title fix: only set loadBalanced on handshake when explicitly set fix(NODE-4591): only set loadBalanced on handshake when explicitly set Aug 26, 2022
@baileympearson baileympearson marked this pull request as ready for review August 26, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants