Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5908): support range v2 #4141

Merged
merged 8 commits into from
Jul 11, 2024
Merged

feat(NODE-5908): support range v2 #4141

merged 8 commits into from
Jul 11, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 11, 2024

Description

What is changing?

This PR adds support for the QE range v2 protocol. This is a breaking change to users of QE range v1 but our support is experimental and subject to change, so this is okay.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Prepare to support range v2

Note

This release includes some experimental features that are not yet ready for production use. As a reminder, anything marked experimental is not a part of the stable driver API and is subject to change without prior notice.

Typescript changes... need bindings 6.1.0+

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title feat(....): support range v2 [skip-ci] feat(....): support range v2 Jun 17, 2024
@nbbeeken
Copy link
Contributor

nbbeeken commented Jun 20, 2024

NODE-5908 From standup: We want to have an official release of the bindings before merging this so we can lift the experimental tag and land the final API at the same time, but this can be reviewed in the meantime

@nbbeeken nbbeeken added the Blocked Blocked on other work label Jun 20, 2024
@baileympearson baileympearson changed the title feat(....): support range v2 feat(NODE-5908): support range v2 Jun 28, 2024
@baileympearson baileympearson removed the Blocked Blocked on other work label Jun 28, 2024
@baileympearson baileympearson marked this pull request as ready for review July 3, 2024 14:46
.evergreen/config.in.yml Outdated Show resolved Hide resolved
.evergreen/generate_evergreen_tasks.js Show resolved Hide resolved
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 8, 2024
@nbbeeken nbbeeken self-requested a review July 8, 2024 21:18
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much LGTM, a couple of small improvements that we can also pass over, lmk if you agree.

Can you add release notes when you get the chance? TIA!

test/tools/runner/hooks/configuration.ts Show resolved Hide resolved
test/integration/node-specific/client_encryption.test.ts Outdated Show resolved Hide resolved
.evergreen/install-mongodb-client-encryption.sh Outdated Show resolved Hide resolved
.evergreen/install-mongodb-client-encryption.sh Outdated Show resolved Hide resolved
.evergreen/install-mongodb-client-encryption.sh Outdated Show resolved Hide resolved
.evergreen/install-mongodb-client-encryption.sh Outdated Show resolved Hide resolved
.evergreen/install-mongodb-client-encryption.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.evergreen/generate_evergreen_tasks.js Outdated Show resolved Hide resolved
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Moving to team review

@aditi-khare-mongoDB aditi-khare-mongoDB added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 10, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit de253a7 into main Jul 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants