-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5908): support range v2 #4141
Conversation
8f1bd53
to
a670c28
Compare
NODE-5908 From standup: We want to have an official release of the bindings before merging this so we can lift the experimental tag and land the final API at the same time, but this can be reviewed in the meantime |
53dcabc
to
d3452d1
Compare
62b6149
to
8495f6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much LGTM, a couple of small improvements that we can also pass over, lmk if you agree.
Can you add release notes when you get the chance? TIA!
...ion/client-side-encryption/client_side_encryption.prose.22.range_explicit_encryption.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Moving to team review
Description
What is changing?
This PR adds support for the QE range v2 protocol. This is a breaking change to users of QE range v1 but our support is experimental and subject to change, so this is okay.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Prepare to support range v2
Note
This release includes some experimental features that are not yet ready for production use. As a reminder, anything marked experimental is not a part of the stable driver API and is subject to change without prior notice.
Typescript changes... need bindings 6.1.0+
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript