Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table load refactor for CFE_TBL_Load()/CFE_TBL_LoadCmd() overlap and complexity reduction #600

Open
CDKnightNASA opened this issue Apr 10, 2020 · 4 comments
Assignees
Labels

Comments

@CDKnightNASA
Copy link
Contributor

CDKnightNASA commented Apr 10, 2020

Is your feature request related to a problem? Please describe.
There's code commonalities between CFE_TBL_LoadCmd() and CFE_TBL_Load().

Also varying use of return vs status codes and many if layers within table load should be refactored to reduce complexity. Goal (per SW Sys Eng Handbook guidance) is cyclomatic complexity of <= 10.

Describe the solution you'd like
Code should be consolidated between CFE_TBL_Load() and CFE_TBL_LoadCmd(). Refactor to simplify/separate into functions.

Requester Info
Christopher.D.Knight@nasa.gov

@CDKnightNASA
Copy link
Contributor Author

Pref. just have LoadCmd() call Load()?

@CDKnightNASA
Copy link
Contributor Author

should wait for #503 to be merged into master.

@skliper skliper changed the title CFE_TBL_Load() and CFE_TBL_LoadCmd() overlap Table load refactor for CFE_TBL_Load()/CFE_TBL_LoadCmd() overlap and complexity reduction Apr 22, 2020
@jphickey
Copy link
Contributor

jphickey commented Mar 1, 2023

I'd like to revive/review this again for the Equuleus cycle. Part of the planned feature set for this release does potentially require an update to the CFE_TBL_Load function, and thus becomes important to break this function up into smaller and more manageable parts to reduce its complexity.

@CDKnightNASA
Copy link
Contributor Author

I'd like to revive/review this again for the Equuleus cycle. Part of the planned feature set for this release does potentially require an update to the CFE_TBL_Load function, and thus becomes important to break this function up into smaller and more manageable parts to reduce its complexity.

Do we want to make major API-breaking redesign changes as part of this? Perhaps we can create a top-level issue and link other issues that we want to implement/fix as part of this redesign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants