Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better (and automatic) version info embedding #97

Open
natsukagami opened this issue May 27, 2023 · 0 comments
Open

Better (and automatic) version info embedding #97

natsukagami opened this issue May 27, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request go Pull requests that update Go code priority:medium Medium priority: Mostly for next minor
Milestone

Comments

@natsukagami
Copy link
Owner

We currently rely on changing essentially doc.go to display the production version and compare with the latest version from GitHub to look for updates:

kjudge/doc.go

Lines 5 to 10 in 6dec3df

// The version and codename of the system.
// We typically pick an anime JK name as the codename for every minor version.
const (
Version = "0.7.4"
Codename = "Maaya Awatsuki"
)

This requires a manual commit for every release (as I have forgotten to do in 0.7.5). Let's look for a way to automate this.

Perhaps something like debug.BuildInfo or https://github.com/docker/metadata-action (to extract and inject metadata during CI builds) would help.

@natsukagami natsukagami added bug Something isn't working enhancement New feature or request priority:medium Medium priority: Mostly for next minor go Pull requests that update Go code labels May 27, 2023
@natsukagami natsukagami added this to the v0.8.0 "Kirifu Megumi" milestone May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request go Pull requests that update Go code priority:medium Medium priority: Mostly for next minor
Projects
None yet
Development

No branches or pull requests

1 participant