Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): skeleZip #129

Merged
merged 1 commit into from
Dec 26, 2018
Merged

feat(core): skeleZip #129

merged 1 commit into from
Dec 26, 2018

Conversation

ognen
Copy link
Member

@ognen ognen commented Dec 26, 2018

A simplified zipper over the Skele tree structure. It is meant to replace
elementZipper which is now deprecated.

skeleZip does not take any configuration and requires explicite annotation of children properties (using @@skele/children) in the tree.

To use it:

import { skeleZip } from '@skele/core'

const rootLoc = skeleZip(state)

A simplified zipper over the Skele tree structure. It is meant to repalce
`elementZipper` which is now deprecated.

`skeleZip` does not take any configuration and **requires** explicite annotation of children  properties (using `@@skele/children`) in the tree.
@ognen ognen requested a review from andon December 26, 2018 13:58
@ognen ognen added zippers performance Performance related issues labels Dec 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 413

  • 16 of 21 (76.19%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 80.936%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/zip/skele/zipperImpl.js 16 21 76.19%
Totals Coverage Status
Change from base Build 412: -0.3%
Covered Lines: 1135
Relevant Lines: 1343

💛 - Coveralls

@ognen ognen merged commit 85d91c8 into master Dec 26, 2018
@ognen ognen deleted the feat/skeleZip branch December 26, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related issues zippers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants