Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store, example): add action creator #1654

Merged
merged 3 commits into from
Mar 29, 2019
Merged

feat(store, example): add action creator #1654

merged 3 commits into from
Mar 29, 2019

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

#1634

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 28, 2019

Preview docs changes for e97b1b3 at https://previews.ngrx.io/pr1654-e97b1b3/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 28, 2019

Preview docs changes for cb58a75 at https://previews.ngrx.io/pr1654-cb58a75/

brandonroberts
brandonroberts requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

modules/store/spec/action_creator.spec.ts Show resolved Hide resolved
projects/example-app/src/app/auth/actions/auth-api.actions.ts Outdated Show resolved Hide resolved
projects/example-app/src/app/books/reducers/books.reducer.spec.ts Outdated Show resolved Hide resolved
projects/example-app/src/app/auth/reducers/auth.reducer.ts Show resolved Hide resolved
@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 28, 2019

Preview docs changes for 93d295e at https://previews.ngrx.io/pr1654-93d295e/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 28, 2019

Preview docs changes for 085ad4a at https://previews.ngrx.io/pr1654-085ad4a/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Mar 28, 2019

Preview docs changes for 78b2275 at https://previews.ngrx.io/pr1654-78b2275/

@brandonroberts brandonroberts merged commit e7fe28b into ngrx:master Mar 29, 2019
King-i pushed a commit to King-i/platform that referenced this pull request Mar 29, 2019
@alex-okrushko @King-i
feat(store): add action creator functions (ngrx#1654)
7a1442c 
Closes ngrx#1480, ngrx#1634
@timdeschryver timdeschryver mentioned this pull request Mar 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex-okrushko @ngrxbot @brandonroberts @timdeschryver