Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): warn when same action is registered #1801

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1758

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 24, 2019

Preview docs changes for e349629 at https://previews.ngrx.io/pr1801-e349629/

@brandonroberts brandonroberts merged commit ecda5f7 into master Apr 25, 2019
@brandonroberts brandonroberts deleted the pr/reducer-warning branch April 25, 2019 02:12
timdeschryver added a commit that referenced this pull request May 8, 2019
brandonroberts pushed a commit that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store: new reducer creator should warn users about duplicate actions within the same reducer
3 participants