fix(schematics): fixed the schematics/action spec template #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for cdded0d at https://previews.ngrx.io/pr2092-cdded0d/ |
|
|
||
| describe('<%= classify(name) %>', () => { | ||
| it('should create an instance', () => { | ||
| expect(new <%= classify(name) %>()).toBeTruthy(); | ||
| expect(new from<%= classify(name)%>.Load<%= classify(name) %>s()).toBeTruthy(); |
There was a problem hiding this comment.
Can you add a test for this?
There was a problem hiding this comment.
ok sure. The new test will check for the content generated by the action spec schematics?
There was a problem hiding this comment.
Correct, for example
There was a problem hiding this comment.
I have added the tests Tim. Can you check them ?
There was a problem hiding this comment.
Suggested change
| expect(new from<%= classify(name)%>.Load<%= classify(name) %>s()).toBeTruthy(); | |
| expect(new<%= classify(name)%>Actions.Load<%= classify(name) %>s()).toBeTruthy(); |
|
Preview docs changes for d065a55 at https://previews.ngrx.io/pr2092-d065a55/ |
brandonroberts
requested changes
Sep 7, 2019
| @@ -1,7 +1,7 @@ | |||
| import { <%= classify(name) %> } from './<%= dasherize(name) %>.actions'; | |||
| import * as from<%= classify(name) %> from './<%= dasherize(name) %>.actions'; | |||
There was a problem hiding this comment.
Suggested change
| import * as from<%= classify(name) %> from './<%= dasherize(name) %>.actions'; | |
| import * as <%= classify(name) %>Actions from './<%= dasherize(name) %>.actions'; |
|
|
||
| describe('<%= classify(name) %>', () => { | ||
| it('should create an instance', () => { | ||
| expect(new <%= classify(name) %>()).toBeTruthy(); | ||
| expect(new from<%= classify(name)%>.Load<%= classify(name) %>s()).toBeTruthy(); |
There was a problem hiding this comment.
Suggested change
| expect(new from<%= classify(name)%>.Load<%= classify(name) %>s()).toBeTruthy(); | |
| expect(new<%= classify(name)%>Actions.Load<%= classify(name) %>s()).toBeTruthy(); |
| `${projectPath}/src/app/foo.actions.spec.ts` | ||
| ); | ||
|
|
||
| expect(fileContent).toMatch(/expect\(new fromFoo.LoadFoos\(\)\)/); |
There was a problem hiding this comment.
Suggested change
| expect(fileContent).toMatch(/expect\(new fromFoo.LoadFoos\(\)\)/); | |
| expect(fileContent).toMatch(/expect\(new FooActions.LoadFoos\(\)\)/); |
|
Preview docs changes for d6af3ca at https://previews.ngrx.io/pr2092-d6af3ca/ |
brandonroberts
approved these changes
Sep 8, 2019
|
Thanks @agugan! |
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
when you use the action schematic to generate an action unit test without creators, you get a failing unit test because of the wrong imports.
Closes #2082
What is the new behavior?
Modified the spec template to properly import the actions and also uses the correct class template inside the test suites
Does this PR introduce a breaking change?
Other information